From 85e31109535f65f99201456b59a0490104bc0a87 Mon Sep 17 00:00:00 2001 From: shaw Date: Fri, 9 Oct 2026 11:10:11 +0800 Subject: [PATCH] fix(lint): check type assertions in web_search history helper and test --- .../service/openai_oauth_web_search_history.go | 3 ++- .../service/openai_oauth_web_search_history_test.go | 12 ++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/backend/internal/service/openai_oauth_web_search_history.go b/backend/internal/service/openai_oauth_web_search_history.go index 123722f495..6a68eb7195 100644 --- a/backend/internal/service/openai_oauth_web_search_history.go +++ b/backend/internal/service/openai_oauth_web_search_history.go @@ -120,7 +120,8 @@ func ensureOpenAIOAuthWebSearchToolForHistory(reqBody map[string]any, responsesL case !responsesLite: reqBody["tools"] = append(tools, cloneOpenAIWebSearchHistoryTool()) case additionalToolsIndex >= 0: - item := input[additionalToolsIndex].(map[string]any) + // additionalToolsIndex is only recorded for map items. + item, _ := input[additionalToolsIndex].(map[string]any) existing, _ := item["tools"].([]any) item["tools"] = append(existing, cloneOpenAIWebSearchHistoryTool()) default: diff --git a/backend/internal/service/openai_oauth_web_search_history_test.go b/backend/internal/service/openai_oauth_web_search_history_test.go index f42b090cad..19b7ef0cfe 100644 --- a/backend/internal/service/openai_oauth_web_search_history_test.go +++ b/backend/internal/service/openai_oauth_web_search_history_test.go @@ -138,7 +138,15 @@ func TestEnsureOpenAIOAuthWebSearchToolForHistoryDoesNotShareToolMap(t *testing. second := map[string]any{"input": []any{map[string]any{"type": "web_search_call"}}} require.True(t, ensureOpenAIOAuthWebSearchToolForHistory(first, false)) require.True(t, ensureOpenAIOAuthWebSearchToolForHistory(second, false)) - first["tools"].([]any)[0].(map[string]any)["external_web_access"] = true - require.Equal(t, false, second["tools"].([]any)[0].(map[string]any)["external_web_access"]) + firstTools, ok := first["tools"].([]any) + require.True(t, ok) + firstTool, ok := firstTools[0].(map[string]any) + require.True(t, ok) + firstTool["external_web_access"] = true + secondTools, ok := second["tools"].([]any) + require.True(t, ok) + secondTool, ok := secondTools[0].(map[string]any) + require.True(t, ok) + require.Equal(t, false, secondTool["external_web_access"]) require.Equal(t, false, openAIWebSearchHistoryTool["external_web_access"]) }