mirror of
https://github.com/Wei-Shaw/sub2api.git
synced 2026-10-16 07:33:06 +08:00
feeeei
c19204289d
登记请求只有金额，提交成功但响应丢失时，管理员重试会把同一笔站外打款再扣 一次返利额度。现在一次登记由 Idempotency-Key 标识，数据库在同一事务内以唯一 约束去重： - user_affiliate_ledger 新增 operation_id（幂等键派生的 SHA-256）与部分唯一 索引（迁移 240）；接口要求 Idempotency-Key，缺失或非法返回 400 - 事务内先以 operation_id 写入占位流水，再解冻、扣减并补写额度快照；同键 重试返回首笔流水的结果并带 X-Idempotency-Replayed，不重复扣减；同键换了 用户或金额返回 409 IDEMPOTENCY_KEY_CONFLICT；额度不足时占位随事务回滚 - 并发的同键请求在唯一索引上等待先到者：先到者提交则返回同一条流水，回滚 则自行登记 - 弹窗在网络错误、超时、5xx、408/409 时锁定用户与金额，重试沿用同一请求与 幂等键；幂等键按管理员、用户、金额暂存于 sessionStorage，登记有确定结果后 释放
248 lines
9.4 KiB
Go
248 lines
9.4 KiB
Go
//go:build unit
|
||
|
||
package service
|
||
|
||
import (
|
||
"context"
|
||
"math"
|
||
"strings"
|
||
"testing"
|
||
|
||
"github.com/stretchr/testify/require"
|
||
)
|
||
|
||
// TestResolveRebateRatePercent_PerUserOverride verifies that per-inviter
|
||
// AffRebateRatePercent overrides the global rate, that NULL falls back to the
|
||
// global rate, and that out-of-range exclusive rates are clamped silently.
|
||
//
|
||
// SettingService is left nil here so globalRebateRatePercent returns the
|
||
// documented default (AffiliateRebateRateDefault = 20%) — this exercises the
|
||
// fallback path without spinning up a settings stub.
|
||
func TestResolveRebateRatePercent_PerUserOverride(t *testing.T) {
|
||
t.Parallel()
|
||
svc := &AffiliateService{}
|
||
|
||
// nil exclusive rate → falls back to global default (20%)
|
||
require.InDelta(t, AffiliateRebateRateDefault,
|
||
svc.resolveRebateRatePercent(context.Background(), &AffiliateSummary{}), 1e-9)
|
||
|
||
// exclusive rate set → overrides global
|
||
rate := 50.0
|
||
require.InDelta(t, 50.0,
|
||
svc.resolveRebateRatePercent(context.Background(), &AffiliateSummary{AffRebateRatePercent: &rate}), 1e-9)
|
||
|
||
// exclusive rate 0 → returns 0 (no rebate, intentional)
|
||
zero := 0.0
|
||
require.InDelta(t, 0.0,
|
||
svc.resolveRebateRatePercent(context.Background(), &AffiliateSummary{AffRebateRatePercent: &zero}), 1e-9)
|
||
|
||
// exclusive rate above max → clamped to Max
|
||
tooHigh := 250.0
|
||
require.InDelta(t, AffiliateRebateRateMax,
|
||
svc.resolveRebateRatePercent(context.Background(), &AffiliateSummary{AffRebateRatePercent: &tooHigh}), 1e-9)
|
||
|
||
// exclusive rate below min → clamped to Min
|
||
tooLow := -5.0
|
||
require.InDelta(t, AffiliateRebateRateMin,
|
||
svc.resolveRebateRatePercent(context.Background(), &AffiliateSummary{AffRebateRatePercent: &tooLow}), 1e-9)
|
||
}
|
||
|
||
// TestIsEnabled_NilSettingServiceReturnsDefault verifies that IsEnabled
|
||
// safely handles a nil settingService dependency by returning the default
|
||
// (off). This protects callers from nil-pointer crashes in misconfigured
|
||
// environments.
|
||
func TestIsEnabled_NilSettingServiceReturnsDefault(t *testing.T) {
|
||
t.Parallel()
|
||
svc := &AffiliateService{}
|
||
require.False(t, svc.IsEnabled(context.Background()))
|
||
require.Equal(t, AffiliateEnabledDefault, svc.IsEnabled(context.Background()))
|
||
}
|
||
|
||
// TestValidateExclusiveRate_BoundaryAndInvalid covers the validator used by
|
||
// admin-facing rate setters: nil is always valid (clear), in-range values
|
||
// are accepted, NaN/Inf and out-of-range values produce a typed BadRequest.
|
||
func TestValidateExclusiveRate_BoundaryAndInvalid(t *testing.T) {
|
||
t.Parallel()
|
||
require.NoError(t, validateExclusiveRate(nil))
|
||
|
||
for _, v := range []float64{0, 0.01, 50, 99.99, 100} {
|
||
v := v
|
||
require.NoError(t, validateExclusiveRate(&v), "value %v should be valid", v)
|
||
}
|
||
|
||
for _, v := range []float64{-0.01, 100.01, -100, 200} {
|
||
v := v
|
||
require.Error(t, validateExclusiveRate(&v), "value %v should be rejected", v)
|
||
}
|
||
|
||
nan := math.NaN()
|
||
require.Error(t, validateExclusiveRate(&nan))
|
||
posInf := math.Inf(1)
|
||
require.Error(t, validateExclusiveRate(&posInf))
|
||
negInf := math.Inf(-1)
|
||
require.Error(t, validateExclusiveRate(&negInf))
|
||
}
|
||
|
||
func TestMaskEmail(t *testing.T) {
|
||
t.Parallel()
|
||
require.Equal(t, "a***@g***.com", maskEmail("alice@gmail.com"))
|
||
require.Equal(t, "x***@d***", maskEmail("x@domain"))
|
||
require.Equal(t, "", maskEmail(""))
|
||
}
|
||
|
||
func TestIsValidAffiliateCodeFormat(t *testing.T) {
|
||
t.Parallel()
|
||
|
||
// 邀请码格式校验同时服务于：
|
||
// 1) 系统自动生成的 12 位随机码（A-Z 去 I/O，2-9 去 0/1）
|
||
// 2) 管理员设置的自定义专属码（如 "VIP2026"、"NEW_USER-1"）
|
||
// 因此校验放宽到 [A-Z0-9_-]{4,32}（要求调用方先 ToUpper）。
|
||
cases := []struct {
|
||
name string
|
||
in string
|
||
want bool
|
||
}{
|
||
{"valid canonical 12-char", "ABCDEFGHJKLM", true},
|
||
{"valid all digits 2-9", "234567892345", true},
|
||
{"valid mixed", "A2B3C4D5E6F7", true},
|
||
{"valid admin custom short", "VIP1", true},
|
||
{"valid admin custom with hyphen", "NEW-USER", true},
|
||
{"valid admin custom with underscore", "VIP_2026", true},
|
||
{"valid 32-char max", "ABCDEFGHIJKLMNOPQRSTUVWXYZ012345", true},
|
||
// Previously-excluded chars (I/O/0/1) are now allowed since admins may use them.
|
||
{"letter I now allowed", "IBCDEFGHJKLM", true},
|
||
{"letter O now allowed", "OBCDEFGHJKLM", true},
|
||
{"digit 0 now allowed", "0BCDEFGHJKLM", true},
|
||
{"digit 1 now allowed", "1BCDEFGHJKLM", true},
|
||
{"too short (3 chars)", "ABC", false},
|
||
{"too long (33 chars)", "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456", false},
|
||
{"lowercase rejected (caller must ToUpper first)", "abcdefghjklm", false},
|
||
{"empty", "", false},
|
||
{"utf8 non-ascii", "ÄÄÄÄÄÄ", false}, // bytes out of charset
|
||
{"ascii punctuation .", "ABCDEFGHJK.M", false},
|
||
{"whitespace", "ABCDEFGHJK M", false},
|
||
}
|
||
for _, tc := range cases {
|
||
tc := tc
|
||
t.Run(tc.name, func(t *testing.T) {
|
||
t.Parallel()
|
||
require.Equal(t, tc.want, isValidAffiliateCodeFormat(tc.in))
|
||
})
|
||
}
|
||
}
|
||
|
||
type affiliateWithdrawCall struct {
|
||
userID int64
|
||
amount float64
|
||
operationID string
|
||
}
|
||
|
||
type affiliateWithdrawRepoStub struct {
|
||
AffiliateRepository
|
||
calls []affiliateWithdrawCall
|
||
result *AffiliateWithdrawResult
|
||
err error
|
||
}
|
||
|
||
func (s *affiliateWithdrawRepoStub) WithdrawQuota(_ context.Context, userID int64, amount float64, operationID string) (*AffiliateWithdrawResult, error) {
|
||
s.calls = append(s.calls, affiliateWithdrawCall{userID: userID, amount: amount, operationID: operationID})
|
||
return s.result, s.err
|
||
}
|
||
|
||
const testAffiliateWithdrawKey = "affiliate-withdraw-7-3f2b8c1e"
|
||
|
||
// TestAdminWithdrawQuota_RejectsInvalidAmount 覆盖线下提现金额校验：非正数、
|
||
// NaN/Inf、舍入到 8 位小数后为 0 或溢出的金额都在服务层拒绝，不进入仓储。
|
||
func TestAdminWithdrawQuota_RejectsInvalidAmount(t *testing.T) {
|
||
t.Parallel()
|
||
for _, amount := range []float64{0, -1, math.NaN(), math.Inf(1), math.Inf(-1), 1e-9, math.MaxFloat64} {
|
||
repo := &affiliateWithdrawRepoStub{}
|
||
svc := &AffiliateService{repo: repo}
|
||
_, err := svc.AdminWithdrawQuota(context.Background(), 1, amount, testAffiliateWithdrawKey)
|
||
require.ErrorIs(t, err, ErrAffiliateWithdrawAmountInvalid, "amount %v", amount)
|
||
require.Empty(t, repo.calls, "amount %v must not reach repository", amount)
|
||
}
|
||
}
|
||
|
||
// TestAdminWithdrawQuota_RejectsInvalidUser 验证缺少目标用户时直接拒绝。
|
||
func TestAdminWithdrawQuota_RejectsInvalidUser(t *testing.T) {
|
||
t.Parallel()
|
||
repo := &affiliateWithdrawRepoStub{}
|
||
svc := &AffiliateService{repo: repo}
|
||
_, err := svc.AdminWithdrawQuota(context.Background(), 0, 1, testAffiliateWithdrawKey)
|
||
require.Error(t, err)
|
||
require.Empty(t, repo.calls)
|
||
}
|
||
|
||
// TestAdminWithdrawQuota_RequiresValidIdempotencyKey 验证幂等键必填且须为
|
||
// 可见 ASCII、不超过 128 字符；不合格的键不进入仓储。
|
||
func TestAdminWithdrawQuota_RequiresValidIdempotencyKey(t *testing.T) {
|
||
t.Parallel()
|
||
cases := []struct {
|
||
key string
|
||
want error
|
||
}{
|
||
{key: "", want: ErrIdempotencyKeyRequired},
|
||
{key: " ", want: ErrIdempotencyKeyRequired},
|
||
{key: "has space", want: ErrIdempotencyKeyInvalid},
|
||
{key: "登记", want: ErrIdempotencyKeyInvalid},
|
||
{key: strings.Repeat("k", 129), want: ErrIdempotencyKeyInvalid},
|
||
}
|
||
for _, tc := range cases {
|
||
repo := &affiliateWithdrawRepoStub{}
|
||
svc := &AffiliateService{repo: repo}
|
||
_, err := svc.AdminWithdrawQuota(context.Background(), 1, 1, tc.key)
|
||
require.ErrorIs(t, err, tc.want, "key %q", tc.key)
|
||
require.Empty(t, repo.calls, "key %q must not reach repository", tc.key)
|
||
}
|
||
}
|
||
|
||
// TestAdminWithdrawQuota_DerivesStableOperationID 验证仓储收到的 operation_id
|
||
// 由幂等键确定性派生：同一个键（含首尾空白）得到同一个值，不同的键得到不同的值，
|
||
// 且不是原始键本身。
|
||
func TestAdminWithdrawQuota_DerivesStableOperationID(t *testing.T) {
|
||
t.Parallel()
|
||
repo := &affiliateWithdrawRepoStub{result: &AffiliateWithdrawResult{LedgerID: 1}}
|
||
svc := &AffiliateService{repo: repo}
|
||
|
||
for _, key := range []string{testAffiliateWithdrawKey, " " + testAffiliateWithdrawKey + " ", testAffiliateWithdrawKey + "-2"} {
|
||
_, err := svc.AdminWithdrawQuota(context.Background(), 42, 10, key)
|
||
require.NoError(t, err)
|
||
}
|
||
|
||
require.Len(t, repo.calls, 3)
|
||
first := repo.calls[0].operationID
|
||
require.Regexp(t, `^[0-9a-f]{64}$`, first)
|
||
require.NotEqual(t, testAffiliateWithdrawKey, first)
|
||
require.Equal(t, first, repo.calls[1].operationID)
|
||
require.NotEqual(t, first, repo.calls[2].operationID)
|
||
}
|
||
|
||
// TestAdminWithdrawQuota_RoundsAmountToLedgerPrecision 验证金额按 8 位小数舍入后
|
||
// 交给仓储，仓储结果原样返回。
|
||
func TestAdminWithdrawQuota_RoundsAmountToLedgerPrecision(t *testing.T) {
|
||
t.Parallel()
|
||
want := &AffiliateWithdrawResult{LedgerID: 9, UserID: 42, Amount: 12.34567891}
|
||
repo := &affiliateWithdrawRepoStub{result: want}
|
||
svc := &AffiliateService{repo: repo}
|
||
|
||
got, err := svc.AdminWithdrawQuota(context.Background(), 42, 12.3456789149, testAffiliateWithdrawKey)
|
||
require.NoError(t, err)
|
||
require.Same(t, want, got)
|
||
require.Len(t, repo.calls, 1)
|
||
require.Equal(t, int64(42), repo.calls[0].userID)
|
||
require.Equal(t, 12.34567891, repo.calls[0].amount)
|
||
}
|
||
|
||
// TestAdminWithdrawQuota_PropagatesRepositoryErrors 验证额度不足与同键不同参数
|
||
// 由仓储判定，服务层原样返回，前端据错误码提示。
|
||
func TestAdminWithdrawQuota_PropagatesRepositoryErrors(t *testing.T) {
|
||
t.Parallel()
|
||
for _, want := range []error{ErrAffiliateQuotaInsufficient, ErrIdempotencyKeyConflict} {
|
||
repo := &affiliateWithdrawRepoStub{err: want}
|
||
svc := &AffiliateService{repo: repo}
|
||
_, err := svc.AdminWithdrawQuota(context.Background(), 1, 1, testAffiliateWithdrawKey)
|
||
require.ErrorIs(t, err, want)
|
||
}
|
||
}
|